AhmedDlshad007 commented on issue #1277: URL: https://github.com/apache/iceberg-go/issues/1277#issuecomment-4783260718
I would like to work on this. Plan: in `TestCreateAzureBucketManagedIdentityCredentialCalled` (io/gocloud/azure_test.go), add an `assert.NotContains(err.Error(), "DefaultAzureCredential")` next to the existing ManagedIdentityCredential assertion, so a regression that fell back to DefaultAzureCredential would be caught (its aggregated error also contains "ManagedIdentityCredential", which the current assertion alone would miss). Happy to follow up with the injectable-credential-constructor test seam if you prefer that approach. Will wait for a maintainer to acknowledge before opening the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
