tanmayrauth commented on code in PR #1284: URL: https://github.com/apache/iceberg-go/pull/1284#discussion_r3464634152
########## schema_test.go: ########## @@ -19,6 +19,8 @@ package iceberg_test Review Comment: The fixture covers the two-arg forms (geometry(srid), geography(srid, algo)) but not the single-arg geography branches — geography(crs) with the default algorithm, and geography(OGC:CRS84, algo) with the default CRS. Those are exactly the cases where Go's Type() drops the default, so they're the most valuable to pin cross-impl. Worth adding fields for them while you're capturing Java output? Totally optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
