Revanth14 commented on code in PR #1284:
URL: https://github.com/apache/iceberg-go/pull/1284#discussion_r3470780634
##########
schema_test.go:
##########
@@ -28,6 +30,26 @@ import (
"github.com/stretchr/testify/require"
)
+// geoSchemaJavaFixtureName is a schema JSON fixture emitted by Apache Iceberg
+// Java SchemaParser.toJson on apache/iceberg main at
+// df6ea0820030d217d5f645469419cdbb3f54a41f.
+//
+// Source schema:
+//
+// new Schema(17, ImmutableList.of(
+// Types.NestedField.required(1, "id", Types.LongType.get()),
+// Types.NestedField.optional(2, "geom",
Types.GeometryType.of("srid:3857")),
+// Types.NestedField.optional(3, "geog",
+// Types.GeographyType.of("srid:4269", EdgeAlgorithm.KARNEY)),
+// Types.NestedField.optional(4, "geog_default_algo",
+// Types.GeographyType.of("srid:4269")),
+// Types.NestedField.optional(5, "geog_default_crs",
+// Types.GeographyType.of("OGC:CRS84", EdgeAlgorithm.KARNEY))))
+//
+// Java and Go write object keys in different orders, so the fixture test pins
+// the raw JSON string literals for field types instead of whole-object bytes.
Review Comment:
Agreed. I added a note that this fixture is scoped to Java's type-string
form and that PyIceberg currently emits quoted CRS values, so this shouldn't be
read as the canonical cross-client format.
The CRS quoting divergence is worth tracking separately. I'll open an issue
for standardizing it across clients and link it here. Kept this PR focused on
pinning the Java/Go fixture behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
