Baunsgaard commented on code in PR #16945:
URL: https://github.com/apache/iceberg/pull/16945#discussion_r3468256868
##########
.github/workflows/spark-ci.yml:
##########
@@ -110,14 +110,21 @@ jobs:
cache-read-only: true
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run tests
+ env:
+ SPARK_VERSION: ${{ matrix.spark }}
+ SCALA_VERSION: ${{ matrix.scala }}
+ TEST_GROUP: ${{ matrix.tests }}
run: |
- if [[ "${{ matrix.tests }}" == "core" ]]; then
- projects=":iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{
matrix.scala }}:check"
+ if [[ "${TEST_GROUP}" == "core" ]]; then
+
projects=(":iceberg-spark:iceberg-spark-${SPARK_VERSION}_${SCALA_VERSION}:check")
else
- projects=":iceberg-spark:iceberg-spark-extensions-${{ matrix.spark
}}_${{ matrix.scala }}:check :iceberg-spark:iceberg-spark-runtime-${{
matrix.spark }}_${{ matrix.scala }}:check"
+ projects=(
+
":iceberg-spark:iceberg-spark-extensions-${SPARK_VERSION}_${SCALA_VERSION}:check"
+
":iceberg-spark:iceberg-spark-runtime-${SPARK_VERSION}_${SCALA_VERSION}:check"
+ )
fi
- ./gradlew -DsparkVersions=${{ matrix.spark }} -DscalaVersion=${{
matrix.scala }} -DflinkVersions= -DkafkaVersions= \
- $projects -Pquick=true -x javadoc -DtestParallelism=auto
+ ./gradlew -DsparkVersions="${SPARK_VERSION}"
-DscalaVersion="${SCALA_VERSION}" -DflinkVersions= -DkafkaVersions= \
+ "${projects[@]}" -Pquick=true -x javadoc -DtestParallelism=auto
Review Comment:
you could consider not having this as part of the PR, to keep it self
contained, and open another one with this change. Just to keep a single
responsibility for each PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
