ajantha-bhat commented on code in PR #16945:
URL: https://github.com/apache/iceberg/pull/16945#discussion_r3475748070
##########
.github/workflows/delta-conversion-ci.yml:
##########
@@ -78,7 +78,7 @@ jobs:
strategy:
max-parallel: 15
matrix:
- jvm: [17, 21]
+ jvm: ${{ fromJson((github.event_name == 'pull_request' &&
contains(github.event.pull_request.labels.*.name, 'full-ci') == false) &&
'[17]' || '[17,21]') }}
Review Comment:
exclude is more confusing IMO (option 2), hence I didn't use it initially.
I can go with option 1 if at all required. It is just a line separation.
For me it looks good as it is since we don't have other options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
