fallintoplace opened a new pull request, #1311: URL: https://github.com/apache/iceberg-go/pull/1311
Summary - record only partition spec and schema IDs that were actually removed - avoid emitting remove updates when no requested IDs match existing metadata - make partition spec removal capacity safe when callers pass more IDs than existing specs Why RemovePartitionSpecs and RemoveSchemas preallocated the removed ID slice with length instead of capacity. That made any non-empty request look like a successful removal, and the emitted update used the requested IDs rather than the IDs that were actually removed. Testing - go test ./table -run 'Test(AddRemovePartitionSpec|RemovePartitionSpecsNoMatchDoesNotUpdate|RemoveSchemas|RemoveSchemasNoMatchDoesNotUpdate)$' -count=1 - go test ./table -count=1 - go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./table/... - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
