rmoff opened a new pull request, #16959:
URL: https://github.com/apache/iceberg/pull/16959

   Backports #16079 to the Flink 1.20 and 2.0 modules, as requested by @pvary 
on that PR.
   
   `FlinkCatalog#createTable` previously failed with a terse 
`IllegalArgumentException: table should be resolved` when given a table kind it 
cannot handle (e.g. a `CatalogMaterializedTable`, see #15318). The improved 
`Preconditions.checkArgument` message now reports the actual table class and 
explains that the Iceberg Flink catalog only supports resolved catalog tables.
   
   This applies the exact same change merged for Flink 2.1 in #16079 to the 
1.20 and 2.0 modules (the `createTable` method is identical across all three).
   
   ## Test plan
   
   - [x] Added `testCreateMaterializedTableIsUnsupported` in 
`TestFlinkCatalogTable` for both 1.20 and 2.0 (runs across all catalog 
parametrizations)
   - [x] `spotlessApply` clean for both modules
   - [x] New tests pass for both modules


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to