fallintoplace commented on code in PR #1259:
URL: https://github.com/apache/iceberg-go/pull/1259#discussion_r3478007877
##########
io/gocloud/blob.go:
##########
@@ -188,25 +284,52 @@ func (bfs *blobFileIO) NewWriter(ctx context.Context,
path string, overwrite boo
nil
}
-func createBlobFS(ctx context.Context, bucket *blob.Bucket, keyExtractor
KeyExtractor) icebergio.IO {
- return &blobFileIO{Bucket: bucket, keyExtractor: keyExtractor, ctx: ctx}
+func createBlobFS(ctx context.Context, bucket *blob.Bucket, keyExtractor
KeyExtractor, extractObject ...objectLocationExtractor) icebergio.IO {
Review Comment:
Thank you for your attention, I will have a look tomorrow evening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
