fallintoplace opened a new pull request, #1259: URL: https://github.com/apache/iceberg-go/pull/1259
Summary - validate S3/GCS/OSS URI authorities before turning locations into object keys - reject wrong-bucket and empty-key object paths instead of treating the bucket name as part of the key - run WalkDir roots through the same extractor so list operations reject the same bad authorities - add S3 and GCS regression coverage for extractor, write, and walk paths Why The old extractor removed the scheme and then tried to trim the configured bucket prefix. If the prefix did not match, a path like s3://other-bucket/data/file.parquet became the key other-bucket/data/file.parquet in the opened bucket. That makes reads, writes, and deletes land under a surprising key instead of failing early. Testing - go test ./io/gocloud -run 'TestDefaultKeyExtractor|TestBlobFileIORejectsWrongBucketObjectPaths|TestBlobFileIOWalkDir' -count=1 - go test ./io/gocloud -count=1 - go test ./io -count=1 - go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./io/gocloud - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
