stevenzwu commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r3482798976


##########
core/src/main/java/org/apache/iceberg/TrackedFileBuilder.java:
##########
@@ -97,6 +96,18 @@ static TrackedFileBuilder from(TrackedFile source, long 
newSnapshotId) {
     return new TrackedFileBuilder(source, newSnapshotId);
   }
 
+  /**
+   * Creates a builder with an externally-constructed TrackingBuilder. Use for 
content_entry rows
+   * whose tracking values come from outside the writer (v4 manifest 
references, projections from
+   * legacy ManifestEntry).
+   */
+  static TrackedFileBuilder explicitTracking(

Review Comment:
   @gaborkaszab following up on [this 
comment](https://github.com/apache/iceberg/pull/16964#discussion_r3479520855) 
from your PR, I am adding this new factory method for the new code path in this 
PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to