stevenzwu commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r3489488141
##########
core/src/main/java/org/apache/iceberg/TrackedFileBuilder.java:
##########
@@ -44,27 +44,30 @@ class TrackedFileBuilder {
private List<Long> splitOffsets = null;
private List<Integer> equalityIds = null;
- // tracking-related fields
- private Tracking sourceTracking = null;
+ // tracking-related deferred mutators applied at build() time
private boolean dvUpdated = false;
private ByteBuffer deletedPositions = null;
private ByteBuffer replacedPositions = null;
/**
* Creates a builder for a newly added data file entry.
*
- * @param newSnapshotId the snapshot ID in which the new tracked file will
be committed
+ * @param newSnapshotId the snapshot ID in which the new tracked file will
be committed, or null
+ * for a staged-write ADDED entry whose snapshot ID will be inherited at
read time from the
+ * manifest's snapshot_id
*/
- static TrackedFileBuilder data(long newSnapshotId) {
+ static TrackedFileBuilder data(Long newSnapshotId) {
Review Comment:
when writing a data file entry to a staged leaf manifest file, the snapshot
id is null and will be inherited from the manifest's snapshot id when written
to the root manifest file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
