gaborkaszab commented on code in PR #17000:
URL: https://github.com/apache/iceberg/pull/17000#discussion_r3492306307
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -106,7 +106,7 @@ static Types.StructType schemaWithContentStats(
RECORD_COUNT,
FILE_SIZE_IN_BYTES,
SPEC_ID,
- Types.NestedField.required(PARTITION_ID, PARTITION_NAME,
partitionType, PARTITION_DOC),
+ Types.NestedField.optional(PARTITION_ID, PARTITION_NAME,
partitionType, PARTITION_DOC),
Review Comment:
the pattern seems to be simply writing ", or null.". I added that to the
existing comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
