rdblue commented on code in PR #17000:
URL: https://github.com/apache/iceberg/pull/17000#discussion_r3502334653
##########
core/src/main/java/org/apache/iceberg/TrackedFileAdapters.java:
##########
@@ -100,7 +100,7 @@ public int specId() {
@Override
public StructLike partition() {
- return file().partition();
+ return file().partition() != null ? file().partition() :
BaseFile.EMPTY_PARTITION_DATA;
Review Comment:
Instead of relying on `BaseFile`, I'd prefer to move this constant to
`PartitionData.empty()` or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
