liucao-dd commented on code in PR #16686:
URL: https://github.com/apache/iceberg/pull/16686#discussion_r3493327002
##########
core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java:
##########
@@ -212,6 +220,86 @@ public void deleteWithDuplicates() {
.containsEntry(SnapshotSummary.REPLACED_MANIFESTS_COUNT, "1");
}
+ @TestTemplate
+ public void deleteDuplicateFilesWithinMultipleManifests() throws Exception {
Review Comment:
Seems like this issue is pretty popular and affecting many. I also ran into
the issue multiple times in production and filed
https://github.com/apache/iceberg/issues/16978 while unaware of this PR. After
the issue was opened there are another 3 PRs working on this same issue haha
(see the linked PRs on the issue)
I've added a cherry-pickable commit for the integration test that failed
most of the times without the fix here, in case it is helpful. The remaining
fix on my PR is mostly a duplicate of this.
https://github.com/apache/iceberg/pull/16984/commits/24ceb0feb47644f99e6539959ba4159c3a1d1144
One of the other PR author went with a merge-after approach while adopting
this test as well - would need some guidance to land the most desirable fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
