HuaHuaY commented on code in PR #16686:
URL: https://github.com/apache/iceberg/pull/16686#discussion_r3497419711
##########
core/src/test/java/org/apache/iceberg/TestSnapshotSummary.java:
##########
@@ -212,6 +220,86 @@ public void deleteWithDuplicates() {
.containsEntry(SnapshotSummary.REPLACED_MANIFESTS_COUNT, "1");
}
+ @TestTemplate
+ public void deleteDuplicateFilesWithinMultipleManifests() throws Exception {
Review Comment:
> this one is passing for me even without the fix
Because this PR merely resolves concurrency conflicts. Concurrency conflicts
themselves cause problems unpredictably; issues may or may not arise.
> I've added a cherry-pickable commit
@liucao-dd Thanks for your test cases. I will cherry pick this commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
