zhjwpku commented on code in PR #790:
URL: https://github.com/apache/iceberg-cpp/pull/790#discussion_r3497348929
##########
src/iceberg/avro/avro_reader.cc:
##########
@@ -209,6 +212,63 @@ struct ReadContext {
std::shared_ptr<::arrow::ArrayBuilder> builder_;
};
+std::shared_ptr<::arrow::DataType> StorageTypeForBuilder(
+ const std::shared_ptr<::arrow::DataType>& type);
+
+std::shared_ptr<::arrow::Field> StorageFieldForBuilder(
+ const std::shared_ptr<::arrow::Field>& field) {
+ return ::arrow::field(field->name(), StorageTypeForBuilder(field->type()),
+ field->nullable(), field->metadata());
+}
+
+// Arrow cannot construct builders for arrow.uuid extension arrays yet, so
build
Review Comment:
I think only `AvroReader` needs this workaround, so I think it's fine to
keep it here for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
