zhjwpku commented on code in PR #790:
URL: https://github.com/apache/iceberg-cpp/pull/790#discussion_r3497369108


##########
src/iceberg/test/parquet_test.cc:
##########
@@ -150,6 +154,13 @@ std::optional<ParquetCodec> FirstUnavailableParquetCodec() 
{
   return std::nullopt;
 }
 
+constexpr std::array<uint8_t, Uuid::kLength> kUuidBytes1 = {

Review Comment:
   `kUuidBytes1/2` are just random UUID values, adding a shared test util file 
might be overkill.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to