rdblue commented on code in PR #17010:
URL: https://github.com/apache/iceberg/pull/17010#discussion_r3501083507
##########
api/src/main/java/org/apache/iceberg/types/IndexByName.java:
##########
@@ -76,9 +82,15 @@ public Map<String, Integer> byName() {
* @return a map from field ID to name
*/
public Map<Integer, String> byId() {
+ // a builder is used to swap key and value
ImmutableMap.Builder<Integer, String> builder = ImmutableMap.builder();
nameToId.forEach((key, value) -> builder.put(value, key));
- return builder.build();
+
+ if (useShortNames) {
+ shortNameToId.forEach((key, value) -> builder.put(value, key));
+ }
+
+ return builder.buildKeepingLast();
Review Comment:
Thanks for looking through the failures and finding this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
