amogh-jahagirdar commented on code in PR #17010:
URL: https://github.com/apache/iceberg/pull/17010#discussion_r3506779666
##########
api/src/main/java/org/apache/iceberg/types/IndexByName.java:
##########
@@ -76,8 +82,15 @@ public Map<String, Integer> byName() {
* @return a map from field ID to name
*/
public Map<Integer, String> byId() {
+ // a builder is used to swap key and value
Review Comment:
Nit: Don't think this comment is particularly useful?
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -195,6 +195,19 @@ public static Map<Integer, String> indexQuotedNameById(
return indexer.byId();
}
+ /**
+ * Indexes the fields of a struct from ID to a flattened name that can be
used for stats struct
+ * field names.
+ *
+ * @param struct a struct type
+ * @return an index from field ID to short names, joined by _
+ */
+ public static Map<Integer, String> indexStatsNames(Types.StructType struct) {
Review Comment:
`indexStatsNameById` to better fit the existing naming convention? I'm good
as it is though, it is pretty clear from the signature that it's by ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
