danielcweeks commented on code in PR #16584: URL: https://github.com/apache/iceberg/pull/16584#discussion_r3501727171
########## core/src/main/java/org/apache/iceberg/rest/responses/UnregisterTableResponse.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest.responses; + +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.rest.RESTResponse; +import org.immutables.value.Value; + +/** + * Represents the response when a table is successfully unregistered from a catalog. + * + * <p>The response carries the table's last metadata location and the corresponding table metadata + * so that the underlying (still present) files can be registered in another catalog. + */ [email protected] +public interface UnregisterTableResponse extends RESTResponse { + String metadataLocation(); + + TableMetadata metadata(); + + @Override + default void validate() { + // nothing to validate as it's not possible to create an invalid instance Review Comment: This isn't right. The validate should check that both the returned metadata location and the table metadata are present. They are both required fields per the spec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
