mkroll-db commented on code in PR #16584:
URL: https://github.com/apache/iceberg/pull/16584#discussion_r3501886784
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -731,6 +732,38 @@ public Table registerTable(
ops, fullTableName(ident), metricsReporter(paths.metrics(ident),
tableClient));
}
+ /**
+ * Unregister a table from the catalog without removing its data or metadata
files.
+ *
+ * <p>This is the opposite of {@link #registerTable(SessionContext,
TableIdentifier, String)}. On
+ * success, the table no longer exists in the catalog and the returned
metadata location can be
+ * used to register the table in another catalog.
+ *
+ * @param context session context
+ * @param identifier a table identifier
+ * @return the last metadata location for the unregistered table
+ */
+ public String unregisterTable(SessionContext context, TableIdentifier
identifier) {
+ Endpoint.check(endpoints, Endpoint.V1_UNREGISTER_TABLE);
+ checkIdentifierIsValid(identifier);
+
+ try {
+ AuthSession contextualSession = authManager.contextualSession(context,
catalogAuth);
+ UnregisterTableResponse response =
+ client
+ .withAuthSession(contextualSession)
+ .post(
+ paths.unregister(identifier),
+ null,
+ UnregisterTableResponse.class,
+ mutationHeaders,
+ ErrorHandlers.tableErrorHandler());
+ return response.metadataLocation();
Review Comment:
I thought the flow is:
```java
String loc = catalog.unregisterTable(sourceIdent); // returns
location string
catalog.registerTable(targetIdent, loc); // reads metadata
internally
```
But thinking about this, his works only for the same catalog not necessarily
across different catalogs.
So +1 on returning the actual `TableMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
