rdblue commented on code in PR #16867:
URL: https://github.com/apache/iceberg/pull/16867#discussion_r3502391563
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -401,6 +579,20 @@ private static void populateTrackingFields(TrackedFile
file) {
tracking.set(MANIFEST_POS_ORDINAL, MANIFEST_POS);
}
+ private static ManifestInfo createManifestInfo() {
Review Comment:
I think this should be a constant, not a method. We don't need to create a
manifest info struct every time, and a method gives no guarantees about the
values produced. It could create random values every time.
If we use a constant, then you can write assertions like
`assertThat(manifest.existingFilesCount()).isEqualTo(manifestInfo.existingFilesCount())`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
