rdblue commented on code in PR #16867:
URL: https://github.com/apache/iceberg/pull/16867#discussion_r3502409363
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -276,6 +282,154 @@ void testDVDeleteFileAdapterRejectsNullDeletionVector() {
.hasMessage("Cannot create DV delete file: no deletion vector");
}
+ @ParameterizedTest
+ @EnumSource(
+ value = FileContent.class,
+ names = {"DATA_MANIFEST", "DELETE_MANIFEST"})
+ void testManifestFileAdapterDelegation(FileContent contentType) {
+ ManifestInfo manifestInfo = createManifestInfo();
+ TrackedFile file =
+ manifestBuilder(contentType)
+ .manifestInfo(manifestInfo)
+ .keyMetadata(ByteBuffer.wrap(new byte[] {7, 8, 9}))
+ .build();
+ populateTrackingFields(file);
Review Comment:
Please remove this and either use a `Tracking` constant or create one
inline. This indirection makes the tests unreadable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
