singhpk234 commented on code in PR #16294:
URL: https://github.com/apache/iceberg/pull/16294#discussion_r3502624862


##########
format/spec.md:
##########
@@ -1908,6 +1910,12 @@ Reading v4 metadata:
 * Relative paths must be resolved against the table location before use (see 
[Path Resolution](#path-resolution))
 * When `location` is omitted, the table location must be provided (see [Table 
Location Specification](#table-location-specification))
 
+Snapshot timestamp changes:
+
+* A snapshot's `timestamp-ms` must be strictly greater than the `timestamp-ms` 
of its parent snapshot on the same branch.
+* The requirement applies only to snapshots committed while the table is at 
format version 4 or higher; snapshots that existed before a table was upgraded 
to v4 are not constrained.

Review Comment:
   how about a case where table was in v3 format and future timestamp was 
committed and now v4 snapshot is committing the right timestamp, this would not 
let v4 timestamp snapshot commit ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to