stevenzwu commented on code in PR #16294: URL: https://github.com/apache/iceberg/pull/16294#discussion_r3502695669
########## format/spec.md: ########## @@ -1908,6 +1910,12 @@ Reading v4 metadata: * Relative paths must be resolved against the table location before use (see [Path Resolution](#path-resolution)) * When `location` is omitted, the table location must be provided (see [Table Location Specification](#table-location-specification)) +Snapshot timestamp changes: + +* A snapshot's `timestamp-ms` must be strictly greater than the `timestamp-ms` of its parent snapshot on the same branch. +* The requirement applies only to snapshots committed while the table is at format version 4 or higher; snapshots that existed before a table was upgraded to v4 are not constrained. Review Comment: v4 snapshot will still be able to commit. assume the "bad" timestamp from a v3 snapshot is `t1`. the v4 snapshot can just increment by 1 ms as `t1+1`, which is the behavior in the Java impl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
