amogh-jahagirdar commented on code in PR #17035:
URL: https://github.com/apache/iceberg/pull/17035#discussion_r3509818112
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -202,7 +311,7 @@ void testCopy() {
assertThat(copy.tracking().status()).isEqualTo(EntryStatus.ADDED);
assertThat(copy.tracking().snapshotId()).isEqualTo(42L);
assertThat(copy.deletionVector().location()).isEqualTo("s3://bucket/dv.puffin");
- assertThat(copy.specId()).isEqualTo(0);
+ assertThat(copy.specId()).isEqualTo(7);
Review Comment:
We build the initial file with spec 7. I feel like we should use
non-zero/non-"default" values in these tests to make sure we're not just
getting lucky on any internal state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
