gaborkaszab commented on code in PR #17035:
URL: https://github.com/apache/iceberg/pull/17035#discussion_r3518288166
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -317,14 +477,43 @@ void testContentStatsNullWhenNotSet() {
void testAllFileContentTypesSupported() {
for (FileContent content : FileContent.values()) {
TrackedFileStruct file = new TrackedFileStruct();
- file.set(CONTENT_TYPE_ORDINAL, content.id());
+ file.set(1, content.id());
assertThat(file.contentType()).isEqualTo(content);
}
}
@Test
void testJavaSerializationRoundTrip() throws IOException,
ClassNotFoundException {
- TrackedFileStruct file = createFullTrackedFile();
+ TrackingStruct tracking =
+ new TrackingStruct(
+ EntryStatus.ADDED,
+ 42L,
+ null,
Review Comment:
Unresolving because the second part of the comment still stands:
"Also, I see creation of Tracking is spelled out in every test. Since we
don't test that class here, isn't that just noise for the sake of all these
tests? Maybe introduce a static member for that as for all the nested
structures?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
