kevinjqliu commented on code in PR #16836:
URL: https://github.com/apache/iceberg/pull/16836#discussion_r3510699501


##########
format/spec.md:
##########
@@ -567,7 +567,7 @@ Partition field IDs must be reused if an existing partition 
spec contains an equ
 
 | Transform name    | Description                                              
    | Source types                                                              
                                | Result type |
 
|-------------------|--------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------|-------------|
-| **`identity`**    | Source value, unmodified                                 
    | Any except for `geometry`, `geography`, and `variant`                     
                                | Source type |
+| **`identity`**    | Source value, unmodified                                 
    | Any primitive type except for `geometry` and `geography`                  
                                | Source type |

Review Comment:
   should we include or exclude variant? 
   
   Dan suggested we can exclude variant
   > Including Variant in the exclusion does create some dissonance because 
it's already covered by the primitive scoping.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to