zhjwpku commented on PR #16836: URL: https://github.com/apache/iceberg/pull/16836#issuecomment-4862746690
> I found these 4 places in the repo where we mention geometry/geography/variant > > * https://github.com/apache/iceberg/blob/d6aa0bf5c244cf6934eaa1820f1a88d099610f7b/format/spec.md#L570 > * https://github.com/apache/iceberg/blob/d6aa0bf5c244cf6934eaa1820f1a88d099610f7b/format/spec.md#L821 > * https://github.com/apache/iceberg/blob/d6aa0bf5c244cf6934eaa1820f1a88d099610f7b/format/expressions-spec.md#L226-L238 > (2 occurrences here) Yeah, the newly added `expressions-spec` uses `Any primitive`, which is aligned with this patch. From the code perspective, `variant` is not a primitive. If we decide to exclude `variant` from the primitive types in the docs, we should keep all of these places aligned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
