HuaHuaY commented on code in PR #16686:
URL: https://github.com/apache/iceberg/pull/16686#discussion_r3518182579
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -300,16 +300,14 @@ private void validateRequiredDeletes(ManifestFile...
manifests) {
}
}
- private Set<F> deletedFiles(ManifestFile[] manifests) {
+ private Set<F> collectDeletedFiles(ManifestFile[] manifests) {
Review Comment:
This change is a leftover from the continuous code refactoring that took
place during implementation; it arose because we added a new call site for this
function. I feel the new name is clearer, but if we want to avoid making too
many changes, I am also open to reverting the rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
