HuaHuaY commented on code in PR #16686:
URL: https://github.com/apache/iceberg/pull/16686#discussion_r3510252870
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -229,6 +228,15 @@ List<ManifestFile> filterManifests(Schema tableSchema,
List<ManifestFile> manife
filtered[index] = manifest;
});
+ for (ManifestFile manifest : filtered) {
Review Comment:
I found that there are some duplicate code between `deletedFiles` and
`collectDeletedFiles` methods. So I changed `deletedFiles(ManifestFile[]
manifests)` to `collectDeletedFiles(Set<F> deletedFiles, ManifestFile[]
manifests)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
