fallintoplace commented on PR #1368: URL: https://github.com/apache/iceberg-go/pull/1368#issuecomment-4881620435
Implemented the deeper fix from zeroshade and kept the shape of the existing code as requested. What I changed: - split fanout coordination vs writer drain contexts in both partitioned data and pos-delete fanout writers (writerCtx/ writerCancel stays alive after fanout workers complete) - switched to closeAll() on successful fanout, abortAll() on error - ensured we cancel writer context only after rolling writers drain in the graceful path - adjusted the new regression test style so it’s clean with repo lints I also fixed the new test lint issues (`nlreturn` + `var`+`=` merge), so the branch is now clean on local `go test ./table -count=1`. I’ve pushed the updated commit(s): `fa73531` on top of `f006261`. I’ll wait for CI re-run and keep an eye out for anything else it surfaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
