zeroshade commented on PR #1368: URL: https://github.com/apache/iceberg-go/pull/1368#issuecomment-4883223064
Thanks @fallintoplace — this is approved and it resolves the #1225 fanout graceful-drain issue, but it now conflicts with main after recent merges. Could you rebase onto the latest main? While you are at it, the earlier optional follow-up still stands: route the unpartitionedWrite success path through closeAndWait so it calls the writer CancelFunc for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
