rdblue commented on code in PR #17035:
URL: https://github.com/apache/iceberg/pull/17035#discussion_r3532488440
##########
core/src/test/java/org/apache/iceberg/TestTrackingStruct.java:
##########
@@ -495,6 +496,16 @@ void testInternalSetIgnoresUnknownOrdinal() {
assertThat(tracking.replacedPositions()).isEqualTo(ByteBuffer.wrap(new
byte[] {3, 4}));
}
+ @Test
+ void testReaderSideFields() {
Review Comment:
The tests for `Tracking` should mirror the `TrackedFile` tests, except that
we can omit the serialization ones (covered by `TrackedFile` tests). I would
probably do that in a separate PR, so it makes sense not to change this right
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
