rdblue commented on code in PR #17035:
URL: https://github.com/apache/iceberg/pull/17035#discussion_r3539324436
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -294,112 +243,52 @@ void testProjectedStructLike() {
}
@Test
- void testContentStatsReturnedWhenPresent() {
- TrackedFileStruct file = createTrackedFileWithStats();
- assertThat(file.contentStats()).isNotNull();
- assertThat(file.contentStats().fieldStats()).hasSize(2);
- }
-
- @Test
- void testContentStatsNullWhenNotSet() {
+ void structLikeSize() {
Review Comment:
I almost made a similar comment yesterday. I think there is little value,
but I think the way this is written, it will start failing if you add a field
to `TrackedFile.schemaWithContentStats` but not this class. That's a good thing
so I think it's worth having this.
Also, we need to rename `TrackedFile.schemaWithContentStats` because it has
a partition and content stats now. I'll follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
