tanmayrauth commented on code in PR #1369:
URL: https://github.com/apache/iceberg-go/pull/1369#discussion_r3539791798
##########
catalog/rest/rest.go:
##########
@@ -552,6 +593,10 @@ func toProps(o *options) iceberg.Properties {
setIf(keyPrefix, o.prefix)
if o.authUri != nil {
+ // Advertise the endpoint under the portable oauth2-server-uri
key while
+ // also retaining the legacy rest.authorization-url alias, so
existing
+ // consumers that read the properties back keep working.
+ setIf(keyOAuth2ServerURI, o.authUri.String())
Review Comment:
Good call, settled on dropping the legacy key. toProps now emits only
oauth2-server-uri, so r.props (and the table config cloned from it) carries the
endpoint under a single canonical name, matching resolveAuthURLAlias/fromProps.
rest.authorization-url is still accepted as an input alias for backward compat;
we just don't advertise it back anymore. I will update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
