zeroshade commented on code in PR #1326:
URL: https://github.com/apache/iceberg-go/pull/1326#discussion_r3553758161
##########
catalog/hadoop/hadoop.go:
##########
@@ -63,6 +64,8 @@ var uuidMetadataPattern = regexp.MustCompile(
`^([0-9]{5})-[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}(?:\.gz)?\.metadata\.json$`,
)
+const metadataClaimStaleAfter = time.Minute
Review Comment:
nit: the stale-claim recovery timeout is hardcoded to 1 minute; a very slow
live committer could lose its claim. It fails safe (errors rather than
publishing duplicate metadata), but a comment noting the tradeoff — or making
it tunable — would help operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
