ebyhr commented on code in PR #3634:
URL: https://github.com/apache/iceberg-python/pull/3634#discussion_r3556315215
##########
tests/expressions/test_literals.py:
##########
@@ -633,6 +633,34 @@ def test_below_min_int() -> None:
assert b.to(IntegerType()) == IntBelowMin()
+def test_above_max_long() -> None:
+ a = LongAboveMax()
+ # singleton
+ assert a == LongAboveMax()
+ assert str(a) == "LongAboveMax"
+ assert repr(a) == "LongAboveMax()"
Review Comment:
What is the motivation of these assertions?
##########
tests/expressions/test_literals.py:
##########
@@ -633,6 +633,34 @@ def test_below_min_int() -> None:
assert b.to(IntegerType()) == IntBelowMin()
+def test_above_max_long() -> None:
+ a = LongAboveMax()
+ # singleton
+ assert a == LongAboveMax()
Review Comment:
Why do we want to verify that `LongAboveMax` is a singleton?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
