ebyhr commented on code in PR #3634:
URL: https://github.com/apache/iceberg-python/pull/3634#discussion_r3561740870
##########
tests/expressions/test_literals.py:
##########
@@ -633,6 +633,20 @@ def test_below_min_int() -> None:
assert b.to(IntegerType()) == IntBelowMin()
+def test_above_max_long() -> None:
Review Comment:
```suggestion
def test_long_above_max_to_error() -> None:
```
##########
tests/expressions/test_literals.py:
##########
@@ -633,6 +633,20 @@ def test_below_min_int() -> None:
assert b.to(IntegerType()) == IntBelowMin()
+def test_above_max_long() -> None:
+ a = LongAboveMax()
Review Comment:
We can inline `a`. Same for `LongBelowMin` test.
##########
tests/expressions/test_literals.py:
##########
@@ -633,6 +633,20 @@ def test_below_min_int() -> None:
assert b.to(IntegerType()) == IntBelowMin()
+def test_above_max_long() -> None:
+ a = LongAboveMax()
+ with pytest.raises(TypeError) as e:
+ a.to(IntegerType())
+ assert "Cannot change the type of LongAboveMax" in str(e.value)
+
+
+def test_below_min_long() -> None:
Review Comment:
```suggestion
def test_long_below_min_to_error() -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
