manuzhang commented on code in PR #2396:
URL: https://github.com/apache/iceberg-rust/pull/2396#discussion_r3556382483
##########
crates/catalog/s3tables/src/catalog.rs:
##########
@@ -218,8 +217,11 @@ impl S3TablesCatalog {
customized_credential_load: None,
})
});
+
+ let file_io_props = map_aws_to_s3_properties(&config.props,
config.endpoint_url.as_ref());
Review Comment:
`endpoint_url` is documented as the S3Tables catalog endpoint, but passing
it to `map_aws_to_s3_properties` also sets `s3.endpoint` when that property is
absent. This makes the control-plane endpoint the object-storage endpoint,
which breaks deployments where those services use different hosts.
Could we pass `None` here and leave the S3 endpoint controlled exclusively
by `s3.endpoint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
