manuzhang commented on code in PR #2396: URL: https://github.com/apache/iceberg-rust/pull/2396#discussion_r3556385070
########## crates/integrations/aws/src/config.rs: ########## @@ -0,0 +1,179 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! AWS SDK configuration utilities. + +use std::collections::HashMap; + +use aws_config::sts::AssumeRoleProvider; +use aws_config::{BehaviorVersion, Region, SdkConfig}; +use aws_sdk_sts::config::Credentials; +use iceberg::io::{ + S3_ACCESS_KEY_ID, S3_ASSUME_ROLE_ARN, S3_ASSUME_ROLE_EXTERNAL_ID, S3_ASSUME_ROLE_SESSION_NAME, + S3_ENDPOINT, S3_REGION, S3_SECRET_ACCESS_KEY, S3_SESSION_TOKEN, +}; + +use crate::{ + AWS_ACCESS_KEY_ID, AWS_ASSUME_ROLE_ARN, AWS_ASSUME_ROLE_EXTERNAL_ID, + AWS_ASSUME_ROLE_SESSION_NAME, AWS_PROFILE_NAME, AWS_REGION_NAME, AWS_SECRET_ACCESS_KEY, + AWS_SESSION_TOKEN, +}; + +/// Creates an aws sdk configuration based on +/// provided properties and an optional endpoint URL. +/// +/// When `client.assume-role.arn` is set, the function first builds a base +/// configuration using any static credentials or profile provided, then uses +/// AWS STS to assume the specified role. The resulting temporary credentials +/// are used for all subsequent AWS API calls. +pub async fn create_sdk_config( + properties: &HashMap<String, String>, + endpoint_uri: Option<&String>, +) -> SdkConfig { + let mut config = aws_config::defaults(BehaviorVersion::latest()); + + if let Some(endpoint) = endpoint_uri { + config = config.endpoint_url(endpoint) + }; + + if properties.is_empty() { + return config.load().await; + } + + if let (Some(access_key), Some(secret_key)) = ( + properties.get(AWS_ACCESS_KEY_ID), + properties.get(AWS_SECRET_ACCESS_KEY), + ) { + let session_token = properties.get(AWS_SESSION_TOKEN).cloned(); + let credentials_provider = + Credentials::new(access_key, secret_key, session_token, None, "properties"); + + config = config.credentials_provider(credentials_provider) + }; + + if let Some(profile_name) = properties.get(AWS_PROFILE_NAME) { + config = config.profile_name(profile_name); + } + + if let Some(region_name) = properties.get(AWS_REGION_NAME) { + let region = Region::new(region_name.clone()); + config = config.region(region); + } + + // If a role ARN is provided, assume that role via STS and use the + // resulting temporary credentials for all AWS SDK calls. + if let Some(role_arn) = properties.get(AWS_ASSUME_ROLE_ARN) { + let base_config = config.load().await; + + let session_name = properties + .get(AWS_ASSUME_ROLE_SESSION_NAME) + .cloned() + .unwrap_or_else(|| "iceberg-aws-catalog".to_string()); Review Comment: The Glue-facing API and issue specify `iceberg-glue-catalog` as the default session name, but the implementation uses `iceberg-aws-catalog`. FileIO also receives no default session-name property and therefore uses its own provider default. Could we use the documented default and propagate it consistently to FileIO? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
