tanmayrauth commented on code in PR #1430:
URL: https://github.com/apache/iceberg-go/pull/1430#discussion_r3560661657
##########
table/table.go:
##########
@@ -157,6 +168,7 @@ func (t *Table) Refresh(ctx context.Context) error {
t.fsF = fresh.fsF
t.metadataLocation = fresh.metadataLocation
t.planner = fresh.planner
+ t.reporter = fresh.reporter
Review Comment:
Fixed it, refresh now only inherits fresh.reporter when the current one is
still the nop default, so a WithMetricsReporter-injected reporter survives the
commit retry loop.
##########
catalog/rest/rest.go:
##########
@@ -834,12 +835,18 @@ func (r *Catalog) tableFromResponse(_ context.Context,
identifier []string, meta
fsF = iceio.LoadFSFunc(config, loc)
}
+ reporter, err := metrics.FromProperties(config)
Review Comment:
Agreed, server-vended selection wasn't intended. Changed to resolve from
r.props so it matches the other catalogs and the client stays in control; if we
ever want servers to drive reporter choice we'll make that an explicit,
documented decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
