tanmayrauth commented on code in PR #1430: URL: https://github.com/apache/iceberg-go/pull/1430#discussion_r3560672771
########## metrics/registry.go: ########## @@ -0,0 +1,89 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package metrics + +import ( + "fmt" + "sync" +) + +// ReporterImplKey is the catalog/table property that selects a registered +// reporter by name (e.g. "logging"). It is the Go analogue of Java's +// metrics-reporter-impl; Go uses a name→factory registry rather than +// reflection over a class name. +const ReporterImplKey = "metrics-reporter-impl" + +// Built-in reporter names usable as the value of [ReporterImplKey]. +const ( + reporterNameNop = "nop" Review Comment: Done, exported ReporterNameNop / ReporterNameLogging and used them in the init() registrations, so callers have symbols instead of bare "nop"/"logging" literals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
