rdblue commented on code in PR #17159:
URL: https://github.com/apache/iceberg/pull/17159#discussion_r3562178554
##########
core/src/main/java/org/apache/iceberg/FieldStats.java:
##########
@@ -18,20 +18,18 @@
*/
package org.apache.iceberg;
-import org.apache.iceberg.types.Type;
+import org.apache.iceberg.types.Types;
-interface FieldStats<T> extends StructLike {
+interface FieldStats<T> {
/** The field ID of the statistic */
int fieldId();
/**
- * The field type of the statistic.
+ * Struct type describing the stats tracked for the field identified by
{@link #fieldId()}.
*
- * <p>For geo types (geometry/geography), this returns the bounding box
struct type (geo_lower /
- * geo_upper) rather than the column's geometry or geography type, because
the type is inferred
- * from the lower/upper bound schema fields.
+ * <p>Note: This type may be a projection of the stats stored in manifest
files.
*/
- Type type();
+ Types.StructType type();
Review Comment:
This changed to the actual schema. The lower and upper bounds types do not
always match (for geo types) so this is the best way to expose types. It is
also more consistent with existing conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
