rdblue commented on code in PR #17159:
URL: https://github.com/apache/iceberg/pull/17159#discussion_r3562228207
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -146,14 +146,7 @@ private TrackedFileStruct(TrackedFileStruct toCopy,
boolean withStats, Set<Integ
this.tracking = toCopy.tracking != null ? toCopy.tracking.copy() : null;
this.sortOrderId = toCopy.sortOrderId;
this.deletionVector = toCopy.deletionVector != null ?
toCopy.deletionVector.copy() : null;
-
- if (withStats && toCopy.contentStats != null) {
- ContentStats filtered = BaseContentStats.buildFrom(toCopy.contentStats,
statsIds).build();
- this.contentStats = filtered.fieldStats().isEmpty() ? null : filtered;
- } else {
- this.contentStats = null;
- }
-
+ this.contentStats = toCopy.contentStats != null ?
toCopy.contentStats.copy() : null;
Review Comment:
Looks like this breaks tests because it doesn't respect `withStats` or
`statsIds` yet. I'll update it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
