zeroshade commented on code in PR #1440:
URL: https://github.com/apache/iceberg-go/pull/1440#discussion_r3566743782
##########
catalog/rest/rest.go:
##########
@@ -804,7 +811,7 @@ func (r *Catalog) createSession(ctx context.Context, opts
*options) (*http.Clien
return cl, nil
}
-func (r *Catalog) fetchConfig(ctx context.Context, opts *options)
(*http.Client, *options, error) {
+func (r *Catalog) fetchConfig(ctx context.Context, opts *options) (*options,
error) {
Review Comment:
Non-blocking: the bootstrap session created solely to fetch `/v1/config` is
discarded without closing idle connections, so initializing many catalogs can
leave idle sockets/goroutines around until transport timeouts (more noticeable
with bootstrap OAuth). Consider calling `CloseIdleConnections()` on
internally-owned bootstrap transports after the config request, or returning a
cleanup handle so user-provided transports aren't closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
