Revanth14 commented on PR #1324: URL: https://github.com/apache/iceberg-go/pull/1324#issuecomment-4961296006
> Re-review: the prior header-suppression-via-context feedback is addressed, but the 404 error-type contract for the follow-up polling layer is still blocking. > > * FetchPlanningResult currently collapses all 404s to ErrPlanExpired; it should decode REST error.type and distinguish NoSuchPlanIdException, NoSuchTableException, and NoSuchNamespaceException. > * FetchScanTasks currently collapses 404s to ErrNoSuchTable; it should expose a distinct NoSuchPlanTask sentinel for NoSuchPlanTaskException. > * The tests pin the lossy empty-body 404 behavior and do not cover FetchScanTasks 404s; add typed REST error-body coverage for the expected cases. Thanks for the re-review. The blocking 404 error-type contract is now addressed: - `FetchPlanningResult` distinguishes `NoSuchPlanIdException`, `NoSuchTableException`, and `NoSuchNamespaceException`. - `FetchScanTasks` now exposes `ErrNoSuchPlanTask` for `NoSuchPlanTaskException` and separately maps missing tables and namespaces. - Bare or unrecognized 404s conservatively remain `ErrRESTError`. - Added typed REST error-body coverage for every expected mapping on both endpoints, plus bare and unrecognized fallback cases. All related inline conversations have been resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
