ebyhr commented on code in PR #17192:
URL: https://github.com/apache/iceberg/pull/17192#discussion_r3574753147
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -935,6 +937,25 @@ public void testEntriesTableReadableMetricsSchema() {
assertThat(actual).as("Dynamic schema for readable_metrics should
match").isEqualTo(expected);
}
+ @TestTemplate
+ public void testPuffinFilesTableSchema() {
+ Table puffinFilesTable = new PuffinFilesTable(table);
+
+ Types.StructType expected =
+ new Schema(
+ required(1, "snapshot_id", Types.LongType.get()),
+ required(2, "statistics_path", Types.StringType.get()),
+ required(3, "file_size_in_bytes", Types.LongType.get()),
+ required(4, "file_footer_size_in_bytes", Types.LongType.get()),
+ required(5, "blob_count", Types.IntegerType.get()),
+ optional(6, "blob_types", Types.ListType.ofRequired(7,
Types.StringType.get())),
+ optional(8, "field_ids", Types.ListType.ofRequired(9,
Types.IntegerType.get())),
+ optional(10, "field_names", Types.ListType.ofOptional(11,
Types.StringType.get())))
Review Comment:
Puffin spec currently supports two blob types `apache-datasketches-theta-v1`
& `deletion-vector-v1`: https://iceberg.apache.org/puffin-spec/#blob-types
Exposing NDV-specific columns is weird to me. We should rename the metadata
table, or change these columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
