abhishekkhanna1 commented on a change in pull request #1997:
URL: https://github.com/apache/iceberg/pull/1997#discussion_r549458214
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
##########
@@ -30,12 +29,6 @@
public class AwsClientFactories {
- /**
- * The implementation class of {@link AwsClientFactory} to customize AWS
client configurations.
- * If set, all AWS clients will be configured by the specified class before
initialization.
- */
- public static final String CLIENT_FACTORY_CONFIG_KEY = "client.factory";
-
private static final SdkHttpClient HTTP_CLIENT_DEFAULT =
UrlConnectionHttpClient.create();
Review comment:
Unrelated to this change:
* Did we consider using SdkAsyncHttpClient such as
[NettyNioAsyncHttpClient](https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.html)
for non blocking IO.
* Should we have different HTTP clients across different services to avoid
contention for the shared connection pool and also have flexibility to
configure the http client settings based on the service?
* Should we use async service clients like S3AsyncClient etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
