jackye1995 commented on a change in pull request #1997:
URL: https://github.com/apache/iceberg/pull/1997#discussion_r549466011
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
##########
@@ -30,12 +29,6 @@
public class AwsClientFactories {
- /**
- * The implementation class of {@link AwsClientFactory} to customize AWS
client configurations.
- * If set, all AWS clients will be configured by the specified class before
initialization.
- */
- public static final String CLIENT_FACTORY_CONFIG_KEY = "client.factory";
-
private static final SdkHttpClient HTTP_CLIENT_DEFAULT =
UrlConnectionHttpClient.create();
Review comment:
Yes we considered about using Netty async implementation and async AWS
client, especially for s3. There was some discussion about that in #1767, and
some people mentioned that Netty implementation has some unresolved bug. Since
the existing solution using java future is good enough, we just chose that
route.
I will do some testing to see if it can improve S3 FileIO performance, and
if it works I will raise another PR. The API for client factory can always be
updated for async clients.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
